Decrement the reference count on the invocation object in _method_callback #81
Conversation
…lback The caller is responsible for doing this according to: https://docs.gtk.org/gio/callback.DBusInterfaceMethodCallFunc.html
| @@ -470,6 +470,8 @@ def _method_callback(self, invocation, interface_name, method_name, | |||
| method_name, | |||
| error | |||
| ) | |||
| finally: | |||
| invocation._unref() | |||
There was a problem hiding this comment.
This looks like a bug in pygobject. Python libraries shouldn't deal with references. I never saw unreferencing in pydbus and it is definitely not happening in dasbus. Could you please report your issue to https://gitlab.gnome.org/GNOME/pygobject?
|
Ok, fair enough. I've filed a bug against pygobject here (i've also referenced this patch, i hope that's OK) |
|
unfortunately, this bug seems to just get kicked back and forth between glib and pygobject. I'm gonna keep running with the workaround from this PR; i don't think either of those projects are going to bend |
|
As an update, i've written a PR for the pygobject library that also addresses this issue |
That is great! Hopefully, it will work out this time. If it gets blocked again please let me know. In that case, I would merge your hotfix for dasbus as a temporary workaround, because I would like to see this issue fixed. |
|
careful merging this though, because if/when the pygobject fix gets merged, you'll have a ref underflow for systems that have an updated pygobject... |
Yes: if merged, a version of PyGObject known to have this bug should be pinned, say By the way, is there a reason for which PyGObject is not listed as a explicit dependency for dasbus? |
|
the upstream fix in PyGObject was merged in April - https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/219 It appears to have been released as of v3.49.0 |
|
I'm closing this, it's fixed upstream in pygobject |
The caller is responsible for doing this according to:
https://docs.gtk.org/gio/callback.DBusInterfaceMethodCallFunc.html
this should fix #80