feat: Add watermark support (DEV-2993) (DEV-2991) #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se to return a boolean for the asset permission response
seakayone
changed the title
seakayone
changed the title
watermark.tif to knora-sipi container
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
===========================================
+ Coverage 11.74% 88.52% +76.77%
===========================================
Files 246 259 +13
Lines 22907 23097 +190
===========================================
+ Hits 2690 20446 +17756
+ Misses 20217 2651 -17566 ☔ View full report in Codecov by Sentry. |
seakayone
changed the title
watermark.tif to knora-sipi containerwatermark.tif to knora-sipi container (DEV-2993)
mpro7
reviewed
Jan 24, 2024
...n/scala/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsMessagesADM.scala
Outdated
Show resolved
Hide resolved
seakayone
changed the title
watermark.tif to knora-sipi container (DEV-2993)…pct:n" notation which allowed n to be outside of 1<=n<=100
… no restriction is returned from the api
mpro7
reviewed
Jan 25, 2024
webapi/src/main/scala/org/knora/webapi/slice/admin/api/ProjectsEndpoints.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/api/ProjectsEndpointsHandler.scala
Show resolved
Hide resolved
It is part of this PR … c28e711 |
Either I will create a followup which lets us update the single statement in the db or it will have to be a manual step. Since we are unsure about if the IMHO, if we update the knora-admin ontology in the db manually it should not keep us from bringing this feature online. |
seakayone
commented
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
watermark.tifto knora-sipi container which is used for watermarking.knora-admin:projectRestrictedViewWatermarkproperty to aboolean.POST admin/projects/[shortcode|iri]/RestrictedViewSettingsendpoints with an optionalwatermarkboolean value.GET admin/files/[shortcode]/filenameandGET admin/projects/[shortcode|iri]/RestrictedViewSettingsendpoints to return thewatermarkboolean.zio-mockdependency and related tests.Depends on dasch-swiss/sipi#405 being released in a new Sipi version.
Updating the knora base version is done in a followup PR #3005
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?