Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Sipi to 3.8.9 #3004

Closed
wants to merge 1 commit into from
Closed

chore: Bump Sipi to 3.8.9 #3004

wants to merge 1 commit into from

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Jan 25, 2024

Pull Request Checklist

Task Description/Number

related to DEV-3221

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Jan 25, 2024

@subotic subotic self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (befe889) 11.64%.
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
- Coverage   11.74%   11.64%   -0.10%     
==========================================
  Files         246      259      +13     
  Lines       22907    23083     +176     
==========================================
- Hits         2690     2688       -2     
- Misses      20217    20395     +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone self-requested a review January 25, 2024 09:24
Copy link
Contributor

@seakayone seakayone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me do this change in PR #3003 so I do not have to resolve the conflict.

@subotic
Copy link
Collaborator Author

subotic commented Jan 25, 2024

Please let me do this change in PR #3003 so I do not have to resolve the conflict.

sure, as you like. I will close this PR and branch then. You need to wait an hour with using the Docker Tag until the stuff is on Dockerhub.

@subotic
Copy link
Collaborator Author

subotic commented Jan 25, 2024

Will be done in #3003.

@subotic subotic closed this Jan 25, 2024
@subotic subotic deleted the wip/bump-sipi branch January 25, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants