Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting resource creation date in bulk import #1151

Merged
merged 8 commits into from
Jan 10, 2019
Merged

Allow setting resource creation date in bulk import #1151

merged 8 commits into from
Jan 10, 2019

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Jan 9, 2019 •
edited
Loading

  • Allow each resource in an API v1 bulk import to specify its creation date.
  • Allow API v2 resource creation to specify a creation date.
  • Add tests.
  • Update docs and release notes.

Resolves #1089.

@benjamingeer benjamingeer requested a review from subotic January 9, 2019 17:26
@benjamingeer benjamingeer mentioned this pull request Jan 9, 2019
Open
subotic
subotic approved these changes Jan 10, 2019
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :-)

@benjamingeer
Copy link
Author

Thanks for the review!

@benjamingeer benjamingeer merged commit 05664ee into develop Jan 10, 2019
@benjamingeer benjamingeer deleted the wip/1089-bulk-import-creation-date branch January 10, 2019 12:56
@benjamingeer benjamingeer mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjamingeer @subotic