chore(standoff): Use Base64-encoded UUIDs in standoff tags #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjamingeer I will do the review on Monday, ok? |
No problem, thanks! |
|
On Monday, I will have fresh energy and be extra annoying ;-) |
|
Ich freue mich auf deine Erbsenzählerei. :) |
| @@ -774,7 +778,7 @@ object StandoffTagUtilV2 { | |||
| case Some(endIndex: String) => Some(endIndex.toInt) | |||
| case None => None | |||
| }, | |||
| uuid = standoffNodes(OntologyConstants.KnoraBase.StandoffTagHasUUID), | |||
| uuid = knoraIdUtil.decodeUuid(standoffNodes(OntologyConstants.KnoraBase.StandoffTagHasUUID)), | |||
There was a problem hiding this comment.
This works both with the old string format and the new shorter UUIDs because KnoraIdUtil.decodeUuid handles both cases:
Is this correct?
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores the UUIDs of standoff tags in Base64 encoding to make them shorter. This should make triplestore query results somewhat shorter. The change is backwards-compatible; existing UUIDs will still work.
StandoffTagV2to store its UUID as ajava.util.UUIDobject instead of a string.KnoraIdUtilto Base64-encode standoff UUIDs.StandoffTagUtilV2to decode Base64-encoded UUIDs.