Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(triplestore): Update Lucene index on startup #1362

Merged
merged 4 commits into from
Jul 2, 2019
Merged

feat(triplestore): Update Lucene index on startup #1362

merged 4 commits into from
Jul 2, 2019

Conversation

benjamingeer
Copy link

  • Rebuild the Lucene index on startup.
  • When a resource's label changes, update the index for that resource. Other data updates create new RDF subjects (because of versioning), so this should only be needed when resource labels change.

Resolves #925.

@benjamingeer benjamingeer requested a review from subotic July 1, 2019 08:54
@benjamingeer benjamingeer self-assigned this Jul 1, 2019
@benjamingeer benjamingeer mentioned this pull request Jul 1, 2019
Open
subotic
subotic approved these changes Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :-)

@benjamingeer
Copy link
Author

Thanks for the review!

@benjamingeer benjamingeer merged commit 3812196 into develop Jul 2, 2019
@benjamingeer benjamingeer deleted the wip/925-lucene branch July 2, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees

@benjamingeer benjamingeer

Labels
API/V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual incremental updating of the Lucene Full-Text-Index
2 participants
@benjamingeer @subotic