Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ark): Document ARK URLs for projects #1408

Merged
merged 4 commits into from
Aug 30, 2019
Merged

docs(ark): Document ARK URLs for projects #1408

merged 4 commits into from
Aug 30, 2019

Conversation

benjamingeer
Copy link

Resolves #1407.

Thanks @mrivoal for asking about this.

@benjamingeer benjamingeer self-assigned this Aug 29, 2019
@benjamingeer benjamingeer changed the title doc(ark): Document ARK URLs for projects docs(ark): Document ARK URLs for projects Aug 29, 2019
@benjamingeer benjamingeer mentioned this pull request Aug 29, 2019
Open
@tobiasschweizer
Copy link
Contributor

tobiasschweizer commented Aug 29, 2019 •
edited
Loading

Wouldn't it make more sense if @mrivoal had a look at this?

@benjamingeer
Copy link
Author

@mrivoal Does this tell you what you need to know?

tobiasschweizer
tobiasschweizer reviewed Aug 29, 2019
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be good to explain that NAAN stands for "Name Assigning Authority Number"

@mrivoal
Copy link

mrivoal commented Aug 29, 2019

Does this tell you what you need to know?

Yes, it does. I was only unsure about the version of a project but I guess there will be various versions of a project description, so that makes perfect sense.

@benjamingeer
Copy link
Author

@mrivoal Sorry, I will clarify that. It isn't the version of the project, but the version of the Knora ARK URL format (currently always 1).

@benjamingeer
Copy link
Author

@mrivoal And thanks for the review!

@mrivoal
Copy link

mrivoal commented Aug 29, 2019

My very first one on Knora :)

@benjamingeer benjamingeer merged commit 1dcf06f into develop Aug 30, 2019
@benjamingeer benjamingeer deleted the wip/1407-project-ark-doc branch August 30, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer left review comments

@mrivoal mrivoal mrivoal approved these changes

Assignees

@benjamingeer benjamingeer

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document ARK URLs for projects
3 participants
@benjamingeer @tobiasschweizer @mrivoal