feat: Add support to load knora-ontologies in the docker-compose stack #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate `POST /admin/store/ResetTriplestoreContent` to Tapir
seakayone
requested review from
mpro7,
BalduinLandolt and
derschnee68
and removed request for
mpro7
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
==========================================
- Coverage 11.74% 11.64% -0.10%
==========================================
Files 246 259 +13
Lines 22907 23083 +176
==========================================
- Hits 2690 2688 -2
- Misses 20217 20395 +178 ☔ View full report in Codecov by Sentry. |
mpro7
requested changes
Jan 23, 2024
webapi/src/main/scala/org/knora/webapi/slice/admin/api/service/StoresRestService.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/api/StoreEndpoints.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/api/StoreEndpoints.scala
Show resolved
Hide resolved
…dpoints.scala Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
mpro7
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
@derschnee68 would like to use the reset endpoint in his app e2e test while having the stack running from the
docker-sompose.yml. Hence the container needs access to thetest_dataandknora-ontologiesfolders.The rest is just refactoring: Migrate
POST /admin/store/ResetTriplestoreContentto Tapir so it shows up in swagger-ui.PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?