Fix language switching and login/logout in SALSAH #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SALSAH.userdata = {lang: 'en'}; | ||
| } | ||
| $.get('lang/' + SALSAH.userdata.lang + '.json', function(data) { | ||
| console.log("Getting language strings: " + SALSAH.userdata.lang) |
There was a problem hiding this comment.
comment out the console output :-)
|
When asking the user if he really wants to change the language of the GUI he should be warned that the page is going to be reloaded (open windows and unsaved changes will be lost). |
|
Have you run the browser tests? Please add a browser test for changing the language. |
|
I added a browser test for changing the language, and the other tests pass, too. |
SepidehAlassi
added a commit
that referenced
this pull request
Dec 13, 2016
* develop: Improve configuration for more concurrent requests (#338) Upgrade to Scala 2.12 (#343) Fix various inconsistencies in knora-base.ttl and docs. (#330) Fix language switching and login/logout in SALSAH (#331) Graph data API operation (#267) Allow connections over HTTPS (#332) Update README.md Add link to GraphDB. fix (salsah): Add missing JavaScript “var”. fix (webapi): Fix RouteUtilV1 so it returns HTML instead of JSON when requested (#326) Ontology and documentation fixes. (#325) fix (salsah): Create multiple links in a resource, and other bug fixes (#315) feature (webapi): Make TransformData fix “test” labels on regions. (#311) Fixes for subclasses and subproperties (#303) Add script to update docs on knora.org (#300) docs: Make trivial change for testing purposes. fix (webapi): CORS problems (#307) Use inference to optimise searches on GraphDB (#301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes language switching in SALSAH. You can click on the language links at the top right corner of the GUI, and the language of GUI prompts changes. This doesn't affect the language of data (such as property labels), which still depend on the user's preferred language (stored in the user's
knora-base:Userin the triplestore).Closes #316.