fix (webapi): add searchbox gui element to hasOtherSomething property #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to review. |
| knora-base:objectClassConstraint knora-base:LinkValue . | ||
| knora-base:objectClassConstraint knora-base:LinkValue ; | ||
|
|
||
| salsah-gui:guiElement salsah-gui:Searchbox . |
There was a problem hiding this comment.
Could you add a newline at the end of the file?
There was a problem hiding this comment.
Sorry I missed that. Added the new line right now.
There was a problem hiding this comment.
Thanks! It shouldn't matter, the triplestore did not complain ;-) It is rather a issue of style.
|
I ran the browser tests for salsah1 and they passed :-) see #829 |
tobiasschweizer
approved these changes
Apr 17, 2018
SepidehAlassi
added a commit
that referenced
this pull request
Apr 30, 2018
* develop: feature (webapi): make project shortcode required (#824) doc (webapi): jekyll / paradox based documentation website (#751) Validate ontologies loaded from the triplestore (#806) fix (webapi): add searchbox gui element to hasOtherSomething property (#828) feature (webapi): allow loading data into graphdb on windows (internal PR) (#814) build (webapi): add missing library (#822) feature (webapi): allow changing of user’s password by system admin (#815) feature (webapi): OpenAPI / Swagger API documentation generation (#812)
SepidehAlassi
added a commit
that referenced
this pull request
Apr 30, 2018
* develop: feature (webapi): make project shortcode required (#824) doc (webapi): jekyll / paradox based documentation website (#751) Validate ontologies loaded from the triplestore (#806) fix (webapi): add searchbox gui element to hasOtherSomething property (#828) feature (webapi): allow loading data into graphdb on windows (internal PR) (#814) build (webapi): add missing library (#822) feature (webapi): allow changing of user’s password by system admin (#815) feature (webapi): OpenAPI / Swagger API documentation generation (#812)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing searchbox gui element for
hasOtherSomethingproperty in the something ontology.fixes #827