-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bulk import parsing bug and limit concurrent client connections #973
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #973 +/- ##
===========================================
- Coverage 82.53% 82.49% -0.05%
===========================================
Files 150 150
Lines 17004 17043 +39
Branches 1627 1623 -4
===========================================
+ Hits 14035 14060 +25
- Misses 2969 2983 +14
Continue to review full report at Codecov.
|
…gurable. - Improve error handling on timeout.
…into fix/971-import-seqnum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This fixes the parsing of properties in
knora-base
that are directly used in project-specific resource classes in XML bulk import data (e.g.knoraXmlImport__seqnum
).It also changes
HttpTriplestoreConnector
andSipiResponder
so they block until getting an HTTP response, to ensure that the number of concurrent HTTP client connections won't exceed the number of instances of these actors.Fixes #971.
Fixes #972.