Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Util for permission handling #142

Merged
merged 6 commits into from
Feb 11, 2020
Merged

Util for permission handling #142

merged 6 commits into from
Feb 11, 2020

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jan 28, 2020 •
edited
Loading

This PR adds a util that handles permission codes returned by Knora.

closes #140

@tobiasschweizer tobiasschweizer added the enhancement Improve existing code or new feature label Jan 28, 2020
@tobiasschweizer tobiasschweizer added this to the 2020-02 milestone Jan 28, 2020
@tobiasschweizer tobiasschweizer self-assigned this Jan 28, 2020
@tobiasschweizer tobiasschweizer changed the title add util for permission handling Util for permission handling Jan 28, 2020
@tobiasschweizer tobiasschweizer mentioned this pull request Jan 28, 2020
Closed
lrosenth
lrosenth approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@lrosenth lrosenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant solution

@tobiasschweizer
Copy link
Contributor Author

note to myself: add it to index.ts

@subotic subotic modified the milestones: 2020-02, 2020-01 Feb 7, 2020
@tobiasschweizer tobiasschweizer merged commit e17e8d7 into master Feb 11, 2020
@tobiasschweizer tobiasschweizer deleted the wip/140-permissions branch February 11, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrosenth lrosenth lrosenth approved these changes

Assignees

@tobiasschweizer tobiasschweizer

Labels
enhancement Improve existing code or new feature
Projects
None yet
Milestone
2020.1
Development

Successfully merging this pull request may close these issues.

Parse Permissions
3 participants
@tobiasschweizer @lrosenth @subotic