Get ontologies by project iri #204
Conversation
|
I will try to do the review this week. |
|
@kilchenmann I will review this PR this afternoon. |
| @@ -119,6 +130,30 @@ export class AppComponent implements OnInit { | |||
| ); | |||
| } | |||
|
|
|||
| getAnythingOntologies() { | |||
There was a problem hiding this comment.
Could you make this one method taking the ontology Iri as a parameter?
You could even make the parameter optional so it would query all ontologies metadata if the param is not provided.
There was a problem hiding this comment.
I can write a helper method getProjectOntologies. The thing is I have to handle the response twice. One response is for anything project ontologies, the other one for dokubib project ontology. I need two separate variables here.
| @@ -60,6 +64,13 @@ export class AppComponent implements OnInit { | |||
|
|
|||
| resourceStatus = ''; | |||
|
|
|||
| itemPluralMapping = { | |||
There was a problem hiding this comment.
What is this used for?
There was a problem hiding this comment.
Is it for use with i18nPlural?
There was a problem hiding this comment.
Yes, it's an example how we can use plural and singular notation and I can test in e2e if it's 3 ontologies or 1 ontology. I know, the js-lib is not the best place to use it, but I thought I want to test it in the test-framework.
There was a problem hiding this comment.
Here's the example: https://angular.io/api/common/I18nPluralPipe
There was a problem hiding this comment.
ok, got it. Thanks for the explanation.
|
@kilchenmann Thanks for the changes. I will check this PR again. |
|
@kilchenmann Is it ok if I look at this PR on Monday? |
|
It's okay. But I have to wait with the next steps... |
|
I will try to do it today then! |
|
I didn't want to stress you out. |
| @@ -60,6 +64,13 @@ export class AppComponent implements OnInit { | |||
|
|
|||
| resourceStatus = ''; | |||
|
|
|||
| itemPluralMapping = { | |||
There was a problem hiding this comment.
ok, got it. Thanks for the explanation.
| @@ -119,6 +130,30 @@ export class AppComponent implements OnInit { | |||
| ); | |||
| } | |||
|
|
|||
| getAnythingOntologies() { | |||
kilchenmann
added
enhancement
Part of DSP-71
Resolves DSP-425
Feature
New method to get ontologies by project IRI. It returns an array of
OntologyMetadata.Chore
Ignore yalc.lock, as it often caused merge conflicts and does not need to be under version control.