DSP-743 Support the api route /health

[kilchenmann]

resolves DSP-743

[tobiasschweizer]

@kilchenmann It is possible to get the headers from an RxJS ajax get request.

    getHealth(): Observable<ApiResponseData<HealthResponse> | ApiResponseError> {
    
        return this.httpGet("").pipe(
            tap(res => console.log(res.xhr.getResponseHeader("server"))),
            map(ajaxResponse => ApiResponseData.fromAjaxResponse(ajaxResponse, HealthResponse, this.jsonConvert)),
            catchError(error => this.handleError(error))
        );
    
    }

I just print out the header using tap: "webapi/v13.0.0-rc.16-11-ga88d20d akka-http/10.1.12"

[tobiasschweizer]

@kilchenmann I added the contents to the test data file in 64c159d

[kilchenmann]

@tobiasschweizer Would it be possible to add it to the response, or how would I read it in the app?

[tobiasschweizer]

Do you already have some logic to parse the server header param?

[tobiasschweizer]

@tobiasschweizer Would it be possible to add it to the response, or how would I read it in the app?

I think we could add the server header param to HealthResponse. This could be handled in the getHealth method after deserialising it using json2typescript.

If you want, I could work on this.

[kilchenmann]

Do you already have some logic to parse the server header param?

No not yet

[kilchenmann]

@tobiasschweizer Would it be possible to add it to the response, or how would I read it in the app?

I think we could add the server header param to HealthResponse. This could be handled in the getHealth method after the deserialising it using json2typescript.

Yes, this was my idea. Would be great if you can work on it. Thanks

[tobiasschweizer]

@kilchenmann 7b890c5 adds functionality to parse the header and add it to the health message. I will probably this in a utility file, so it can be called from the endpoint. Also I will add tests that check the error handling works as expected.

[tobiasschweizer]

@kilchenmann I think we should make a DSP task so we can get test data for the health response message. I don't know how we can get test data for the headers.

[tobiasschweizer]

I created https://dasch.myjetbrains.com/youtrack/issue/DSP-816 so Knora generates test data for the health route.

[kilchenmann]

I created https://dasch.myjetbrains.com/youtrack/issue/DSP-816 so Knora generates test data for the health route.

Do we have to wait for it? Or can we update the tests in a later PR?

[tobiasschweizer]

I created https://dasch.myjetbrains.com/youtrack/issue/DSP-816 so Knora generates test data for the health route.

Do we have to wait for it? Or can we update the tests in a later PR?

I think we'll have to wait. I created https://dasch.myjetbrains.com/youtrack/issue/DSP-817.

[tobiasschweizer]

Ok, I will check this PR this morning.

[kilchenmann]

I am not allowed to review my PR myself. So, I approve the changes from @tobiasschweizer: It works well

[tobiasschweizer]

ok, the PR is good to go!