Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docs #264
Improve Docs #264
Changes from 43 commits
301c858
29a5628
33a189a
3940e24
dbdfb4f
62a448a
d6610ae
58dfde0
b3bac36
6d5aaea
03d545f
ca82469
42c78e9
b7731a7
af6ba05
6e43437
c24625b
351d771
06e3a3f
02c469b
546eefb
7555523
b4d3bfe
bf5173d
455dfcf
2b9088f
22bf185
a7324ae
12ee1fd
990add9
06de95d
6eb201a
72f982e
a5c8571
8cff541
bde6ec5
5de46d4
0f89bc3
83a3c1f
d00560f
5c3918a
f120a33
899c4fe
12cd1f1
8a12b84
cc70b8e
9e1e420
ade326d
3701f22
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have two periods here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 12cd1f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Make sure that your version of 'rxjs' is major version 6 with..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 12cd1f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"if, for some reason, the request failed"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 12cd1f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would link it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
@kilchenmann Could this be done as a step of the build process when moving them to docs.dasch.swiss?
Or could we actually link the source file on GitHub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in any case, this file will be shown on npmjs.com. So whatever we do, it also needs to make sense there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment you could set the link to the file in github repo:
https://github.com/dasch-swiss/dsp-js-lib/blob/main/contribution.md
same with design-documentation:
https://github.com/dasch-swiss/dsp-js-lib/blob/main/design-documentation.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about versions? If you release the npm package, then these links will always point to the latest version in
main
which could be different from the release.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could use the GitHub permalinks, but I am not sure how hard it would be to manage them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my point of every comment suggesting the link. Linking makes life way easier. One just can click to open in external tab and keep read the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then you have to update the linked version in the README before releasing?
It can be tricky and as you said "hard to manage".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just mention that link follows to the newest version - which helps to remember to look for the version one is checking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same thing happens to the badge at the top of the README. It displays always the latest version.