Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(endpoint)!: resolve set-cookie issue (DSP-1827) #361

Merged
merged 2 commits into from
Jul 28, 2021
Merged

fix(endpoint)!: resolve set-cookie issue (DSP-1827) #361

merged 2 commits into from
Jul 28, 2021

Conversation

kilchenmann
Copy link
Contributor

resolves DSP-1827

@kilchenmann kilchenmann self-assigned this Jul 28, 2021
@kilchenmann kilchenmann added bug Something isn't working enhancement Improve existing code or new feature labels Jul 28, 2021
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jul 28, 2021 •
edited
Loading

This is how it works now:

Compare old with new request headers

@kilchenmann kilchenmann requested review from mdelez and subotic July 28, 2021 10:01
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Jul 28, 2021 •
edited
Loading

btw. for the reviewers: if you want to test it with the test-framework you have to open it on the same domain as the api is running e.g. http://0.0.0.0:4200 and you should see the cookie in the request headers if it was set on login.

Screen Shot 2021-07-28 at 12 14 30

Edit: Or we could set crossDomain to true? Not sure if this works. I'll try after lunch....

subotic
subotic approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! LGTM

@kilchenmann
Copy link
Contributor Author

Edit: Or we could set crossDomain to true? Not sure if this works. I'll try after lunch....

No, crossDomain does not work. Not sure if it's supported from the API-side!?

mdelez
mdelez approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well!

@kilchenmann kilchenmann merged commit a5cde5d into main Jul 28, 2021
@kilchenmann kilchenmann deleted the wip/dsp-1827-set-cookie branch July 28, 2021 12:24
@daschbot daschbot mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

@subotic subotic subotic approved these changes

Assignees

@kilchenmann kilchenmann

Labels
bug Something isn't working enhancement Improve existing code or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilchenmann @subotic @mdelez