Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use stillimagefilevaluehasexternalurl (DEV-4109) #648

Merged
merged 4 commits into from
Sep 30, 2024
Merged

refactor: use stillimagefilevaluehasexternalurl (DEV-4109) #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46ea61f
refactor: use stillImageFileValueHasExternalUrl instead of fileValueH…
domsteinbach Sep 30, 2024
acb1fb3
chore: mark as deprecated
domsteinbach Sep 30, 2024
1f6b40b
feat: update versions
domsteinbach Sep 30, 2024
6068a82
chore
domsteinbach Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dasch-swiss/dsp-js",
"version": "10.2.1",
"version": "10.2.2",
"description": "JavaScript library that handles API requests to Knora",
"main": "index.js",
"files": [
Expand Down
3 changes: 3 additions & 0 deletions src/models/v2/Constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ export class Constants {
static StillImageFileValueHasDimX = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasDimX";
static StillImageFileValueHasDimY = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasDimY";
static StillImageFileValueHasIIIFBaseUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasIIIFBaseUrl";
/**
* @deprecated FileValueHasExternalUrl will be removed in future versions. Use StillImageFileValueHasExternalUrl instead.
*/
static FileValueHasExternalUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "fileValueHasExternalUrl";
static StillImageFileValueHasExternalUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasExternalUrl";
static AudioFileValueHasDuration = Constants.KnoraApiV2 + Constants.HashDelimiter + "audioFileValueHasDuration";
Expand Down
2 changes: 1 addition & 1 deletion src/models/v2/resources/values/create/create-file-value.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class CreateStillImageFileValue extends CreateFileValue {
*/
@JsonObject("CreateStillImageExternalFileValue")
export class CreateStillImageExternalFileValue extends CreateFileValue {
@JsonProperty(Constants.FileValueHasExternalUrl, String, true)
@JsonProperty(Constants.StillImageFileValueHasExternalUrl, String, true)
externalUrl?: string = "";
constructor() {
super(Constants.StillImageExternalFileValue);
Expand Down
2 changes: 1 addition & 1 deletion src/models/v2/resources/values/update/update-file-value.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class UpdateStillImageFileValue extends UpdateFileValue {
*/
@JsonObject("UpdateStillImageExternalFileValue")
export class UpdateExternalStillImageFileValue extends UpdateFileValue {
@JsonProperty(Constants.FileValueHasExternalUrl, String, true)
@JsonProperty(Constants.StillImageFileValueHasExternalUrl, String, true)
externalUrl: string;
constructor() {
super(Constants.StillImageExternalFileValue);
Expand Down
2 changes: 1 addition & 1 deletion vars.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ else
endif

API_REPO := dasch-swiss/dsp-api
API_VERSION := v30.18.2
API_VERSION := v30.18.4
Loading