fix(xmlupload): permission for uri value serialise (DEV-3630) (#958)

dasch-swiss · May 14, 2024 · 79a11bb · 79a11bb
1 parent 0289294
commit 79a11bb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/dsp_tools/commands/xmlupload/models/serialise/serialise_value.py b/src/dsp_tools/commands/xmlupload/models/serialise/serialise_value.py
@@ -19,7 +19,7 @@ class SerialiseValue(Protocol):
     """A value to be serialised."""
 
     value: str
-    permissions: str
+    permissions: str | None
     comment: str | None
 
     def serialise(self) -> dict[str, Any]:
@@ -31,20 +31,21 @@ class SerialiseURI(SerialiseValue):
     """A URI to be serialised."""
 
     value: str
-    permissions: str
+    permissions: str | None
     comment: str | None
 
     def serialise(self) -> dict[str, Any]:
         """Serialise the URI value."""
 
         serialised = {
             "@type": "knora-api:UriValue",
-            "knora-api:hasPermissions": self.permissions,
             "knora-api:uriValueAsUri": {
                 "@type": "xsd:anyURI",
                 "@value": self.value,
             },
         }
         if self.comment:
             serialised["knora-api:valueHasComment"] = self.comment
+        if self.permissions:
+            serialised["knora-api:hasPermissions"] = self.permissions
         return serialised
diff --git a/src/dsp_tools/commands/xmlupload/resource_create_client.py b/src/dsp_tools/commands/xmlupload/resource_create_client.py
@@ -365,15 +365,17 @@ def _make_time_value(value: XMLValue) -> dict[str, Any]:
 def _serialise_uri_prop(prop: XMLProperty, permissions_lookup: dict[str, Permissions]) -> dict[str, Any]:
     uri_values: list[SerialiseValue] = []
     for v in prop.values:
-        value_permission = cast(str, v.permissions)
-        if not (per := permissions_lookup.get(value_permission)):
-            raise PermissionNotExistsError(f"Could not find permissions for value: {v.permissions}")
-        per_str = str(per)
+        if v.permissions:
+            if not (per := permissions_lookup.get(v.permissions)):
+                raise PermissionNotExistsError(f"Could not find permissions for value: {v.permissions}")
+            permission = str(per)
+        else:
+            permission = None
         uri = cast(str, v.value)
         uri_values.append(
             SerialiseURI(
                 value=uri,
-                permissions=per_str,
+                permissions=permission,
                 comment=v.comment,
             )
         )