Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(xmlupload): serialise all values with rdflib #1287

Merged
merged 63 commits into from
Nov 21, 2024
Merged

refactor(xmlupload): serialise all values with rdflib #1287

merged 63 commits into from
Nov 21, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

@Nora-Olivia-Ammann Nora-Olivia-Ammann commented Nov 20, 2024 •
edited
Loading

Changes in the PR

  • All values are made with rdflib
  • I removed all the classes that did the serialisation
  • I implemented the functional approach as much as possible. Some Values are too different (eg. Date) to include them in the generic workflow.

Future Work

  • FileValues will be serialised in a separate PR, I will do this before I implement the new feature with the license / copyright
  • I will wait to change the serialisation of the resource until API: Release 30.21.0 (chore(main): Release 30.21.0 dsp-api#3381) is live, because from then onwards, the API can parse any type of json-ld. It is not clear when exactly this happens because as discussed in cycle planning, they will not take the newest API version in the next release.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Nov 20, 2024
@Nora-Olivia-Ammann
Update serialise_rdf_value.py
2063da8
@Nora-Olivia-Ammann
Update serialise_rdf_value.py
49c2f25
@Nora-Olivia-Ammann
Update serialise_rdf_value.py
4547371
@Nora-Olivia-Ammann
change
f336092
@Nora-Olivia-Ammann
remove redundant code
e64929f
@Nora-Olivia-Ammann
Update transform_resource_and_values_for_upload.py
7f6b350
@Nora-Olivia-Ammann
link
77c483c
@Nora-Olivia-Ammann
Update transform_resource_and_values_for_upload.py
8483a13
@Nora-Olivia-Ammann
-
d6fa0fe
@Nora-Olivia-Ammann
Update transform_resource_and_values_for_upload.py
be0dc7b
@Nora-Olivia-Ammann
Update transform_resource_and_values_for_upload.py
11cf1c1
@Nora-Olivia-Ammann
-
88d1830
@Nora-Olivia-Ammann
Update transform_resource_and_values_for_upload.py
57f72da
@Nora-Olivia-Ammann
Update serialise_rdf_value.py
8b0909f
@Nora-Olivia-Ammann
remove boolean
2850879
@Nora-Olivia-Ammann
make interval rdf
5048b93
@Nora-Olivia-Ammann
remove serialise value
c2e021e
@Nora-Olivia-Ammann
Update transform_resource_and_values_for_upload.py
846d73a
@Nora-Olivia-Ammann
Update transform_resource_and_values_for_upload.py
f21b52c
@Nora-Olivia-Ammann
change value transformers
ece186d
@Nora-Olivia-Ammann
move tests
2cb1213
@Nora-Olivia-Ammann
Update test_value_transformers.py
44fdec8
@Nora-Olivia-Ammann
linting
a043d63
jnussbaum
jnussbaum approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments, but generally, it looks good.

src/dsp_tools/commands/xmlupload/models/serialise/serialise_rdf_value.py Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/transform_resource_and_values_for_upload.py Outdated Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/transform_resource_and_values_for_upload.py Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/transform_resource_and_values_for_upload.py Show resolved Hide resolved
src/dsp_tools/commands/xmlupload/transform_resource_and_values_for_upload.py Show resolved Hide resolved
test/unittests/commands/xmlupload/test_transform_resource_and_values_for_upload.py Outdated Show resolved Hide resolved
test/unittests/commands/xmlupload/test_transform_resource_and_values_for_upload.py Show resolved Hide resolved
test/unittests/commands/xmlupload/test_transform_resource_and_values_for_upload.py Outdated Show resolved Hide resolved
test/unittests/commands/xmlupload/test_transform_resource_and_values_for_upload.py Outdated Show resolved Hide resolved
test/unittests/commands/xmlupload/test_value_transformers.py Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 3728089 into main Nov 21, 2024
14 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the refactor-serialise-all-values-with-rdflib branch November 21, 2024 12:47
@daschbot daschbot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nora-Olivia-Ammann @jnussbaum