Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get): prevent invalid gui_element "Pulldown" (DEV-1781) #312

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1781

@jnussbaum jnussbaum self-assigned this Mar 2, 2023
@linear
Copy link

linear bot commented Mar 2, 2023

DEV-1781 DSP-TOOLS: workaround to prevent gui_element Pulldown

If you execute dsp-tools get -s https://api.demo.dasch.swiss -u rootexample.com -p demo6783 -P 0790 mark16.json, you get a list-property with the invalid gui_element Pulldown:

{
    "name": "test-subjects",
    "super": [
        "hasValue"
    ],
    "object": "ListValue",
    "labels": {
        "en": "subjects"
    },
    "gui_element": "Pulldown",
    "gui_attributes": {
        "hlist": "R6e67svWRQKdjDnAOM0vBg"
    }
}

As can be seen in the list name, this must originate from a list created via DSP-APP.

We already had similar issues:

This should be fixed in DSP-APP / DSP-API, but I will add a temporary workaround in DSP-TOOLS.

@jnussbaum
Copy link
Collaborator Author

See description in ticket for more background info

@jnussbaum jnussbaum requested a review from BalduinLandolt March 2, 2023 09:36
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnussbaum jnussbaum merged commit c5d355e into main Mar 2, 2023
@jnussbaum jnussbaum deleted the wip/dev-1781-gui-element-pulldown branch March 2, 2023 12:40
@daschbot daschbot mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants