Refactor how to get properties by type #88
Conversation
|
As long as there isn't a new RC for the JS lib, it has to be built manually.
|
|
@flavens Hopefully Non Breaking News: @knora/api@1.0.0-rc.1 is out!!! |
projects/dsp-ui/src/lib/viewer/views/resource-view/resource-view.component.ts
Show resolved
Hide resolved
projects/dsp-ui/src/lib/viewer/views/property-view/property-view.component.spec.ts
Show resolved
Hide resolved
| @@ -1,8 +1,8 @@ | |||
| <div class="resource-view" *ngIf="resource"> | |||
|
|
|||
| <!-- dsp-property-view --> | |||
| <div *ngIf="propArray.length !== 0; else noProperty"> | |||
| <dsp-property-view [parentResource]="resource" [propArray]="propArray" [systemPropArray]="systemPropArray"> | |||
| <div *ngIf="resPropInfoVals.length !== 0 || systemPropDefs.length !== 0; else noProperty"> | |||
There was a problem hiding this comment.
Is this check necessary? How would PropertyViewComponent behave if both resPropInfoVals and systemPropDefs are empty arrays?
You don't have to worry about not initialised members because bot arrays are initialised with an empty array. I think that's a good practice.
There was a problem hiding this comment.
ok so I could remove this check but we should manage somehow the case where we get empty arrays, the user should know that there is no properties
There was a problem hiding this comment.
Ok, fine with me if you leave this check.
There was a problem hiding this comment.
I mean, the current way it is implemented is fine :-)
projects/dsp-ui/src/lib/viewer/views/property-view/property-view.component.spec.ts
Show resolved
Hide resolved
projects/dsp-ui/src/lib/viewer/views/resource-view/resource-view.component.ts
Show resolved
Hide resolved
For more info: DSP-142 and DSP-275