Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ijg jpeg lib to v9f, partially fixes DEV-3474 #449

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Jul 22, 2024

As far as I understand, the core of the issue is that the ijg library used not to correctly recognize when the 4 channel colorspace is actually YCCA, which is likely (but I can't say with 100% certainty) fixed in v9e: libjpeg-turbo/ijg@ff9491d#diff-71516311e7ecc262ab53731fc7ec0ea1c6d50ff9367bdea67804f9af5c9015e5L165-R180

I discovered where the bug lies after checking that the values of a image of just cyan (100%, 0%, 0%, 0%) are 0, 255, 255, 255, so it could not have been the fault of the image profile convertor (LittleCMS, in this case. In addition, I tried setting all the parameters for LCMS manually and tested it with a byte array, which was all correct.)

Knowing the root cause, additional reports of such problems can be found, because this feature space is dependent on vendor markers and likely not tested as extensively.

With the ijg lib updated to v9f, the original file attached in the issue is getting converted correctly, although files converted with imagemagick still remain black.

Copy link

linear bot commented Jul 22, 2024

@siers siers requested a review from subotic July 22, 2024 15:07
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.5%. Comparing base (2a30eee) to head (5fd53d4).

Additional details and impacted files

see 4 files with indirect coverage changes

Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@siers siers merged commit 94e72fa into main Jul 23, 2024
10 checks passed
@siers siers deleted the fix/cmyk-conversion-bug-DEV-3474 branch July 23, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants