fix(custom-resources): custom resource response may silently get drop…

…ped (aws#28826) It looks like in our custom resource response senders, we are not checking the HTTP result code of making the `PUT` request to the presigned URL. This allows for the possibility that we don't detect that we got a 500, exit successfully, and drop the response on the floor. Also log the URL we're writing to so that it becomes easier to debug missing object PUTs. (Yes, I am aware that there is awkward duplication going on here. I'm trying to get this out quickly, and doing a full refactor will take me time that I don't have to spend on this) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
daschaa · Feb 26, 2024 · c52ff08 · c52ff08
1 parent 040a1fb
commit c52ff08
Show file tree

Hide file tree

Showing 555 changed files with 58,223 additions and 122,958 deletions.
diff --git a/.../asset.016b31fb837932c47671b508267ca99838d8f8d67b359052a9ab42b43134902b/__entrypoint__.js b/.../asset.016b31fb837932c47671b508267ca99838d8f8d67b359052a9ab42b43134902b/__entrypoint__.js
diff --git a/...08155a3f0b415fb7a1e0dd94dabe4db9/index.js → ...38d8f8d67b359052a9ab42b43134902b/index.js b/...08155a3f0b415fb7a1e0dd94dabe4db9/index.js → ...38d8f8d67b359052a9ab42b43134902b/index.js
diff --git a/.../asset.b9536659d3370f43ff14b165155a584cff2826a52ce2a1d03d524e47f4933cbf/__entrypoint__.js b/.../asset.b9536659d3370f43ff14b165155a584cff2826a52ce2a1d03d524e47f4933cbf/__entrypoint__.js
diff --git a/...a63157f6da5ae14acdb0bb9cf5c99aa8/index.js → ...ff2826a52ce2a1d03d524e47f4933cbf/index.js b/...a63157f6da5ae14acdb0bb9cf5c99aa8/index.js → ...ff2826a52ce2a1d03d524e47f4933cbf/index.js
diff --git a/.../asset.e585d45530f6ac41c9820a8d4a613c60a63157f6da5ae14acdb0bb9cf5c99aa8/__entrypoint__.js b/.../asset.e585d45530f6ac41c9820a8d4a613c60a63157f6da5ae14acdb0bb9cf5c99aa8/__entrypoint__.js
diff --git a/.../asset.efed83658c390f4cf6b11ee3102d0915b4e59221bffb59919511e5653e6db7f9/__entrypoint__.js b/.../asset.efed83658c390f4cf6b11ee3102d0915b4e59221bffb59919511e5653e6db7f9/__entrypoint__.js
diff --git a/....snapshot/asset.efed83658c390f4cf6b11ee3102d0915b4e59221bffb59919511e5653e6db7f9/index.js b/....snapshot/asset.efed83658c390f4cf6b11ee3102d0915b4e59221bffb59919511e5653e6db7f9/index.js
diff --git a/...ork-integ/test/aws-cloudfront/test/integ.cloudfront-cross-region-cert.js.snapshot/cdk.out b/...ork-integ/test/aws-cloudfront/test/integ.cloudfront-cross-region-cert.js.snapshot/cdk.out
diff --git a/...loudfront/test/integ.cloudfront-cross-region-cert.js.snapshot/integ-acm-stack.assets.json b/...loudfront/test/integ.cloudfront-cross-region-cert.js.snapshot/integ-acm-stack.assets.json
diff --git a/...udfront/test/integ.cloudfront-cross-region-cert.js.snapshot/integ-acm-stack.template.json b/...udfront/test/integ.cloudfront-cross-region-cert.js.snapshot/integ-acm-stack.template.json
@@ -89,7 +89,7 @@
    "Properties": {
     "Code": {
      "S3Bucket": "cdk-hnb659fds-assets-12345678-us-east-1",
-     "S3Key": "efed83658c390f4cf6b11ee3102d0915b4e59221bffb59919511e5653e6db7f9.zip"
+     "S3Key": "016b31fb837932c47671b508267ca99838d8f8d67b359052a9ab42b43134902b.zip"
     },
     "Timeout": 900,
     "MemorySize": 128,

diff --git a/...nt/test/integ.cloudfront-cross-region-cert.js.snapshot/integ-cloudfront-stack.assets.json b/...nt/test/integ.cloudfront-cross-region-cert.js.snapshot/integ-cloudfront-stack.assets.json
diff --git a/.../test/integ.cloudfront-cross-region-cert.js.snapshot/integ-cloudfront-stack.template.json b/.../test/integ.cloudfront-cross-region-cert.js.snapshot/integ-cloudfront-stack.template.json
@@ -104,7 +104,7 @@
    "Properties": {
     "Code": {
      "S3Bucket": "cdk-hnb659fds-assets-12345678-us-east-2",
-     "S3Key": "e585d45530f6ac41c9820a8d4a613c60a63157f6da5ae14acdb0bb9cf5c99aa8.zip"
+     "S3Key": "b9536659d3370f43ff14b165155a584cff2826a52ce2a1d03d524e47f4933cbf.zip"
     },
     "Timeout": 900,
     "MemorySize": 128,

diff --git a/...-integ/test/aws-cloudfront/test/integ.cloudfront-cross-region-cert.js.snapshot/integ.json b/...-integ/test/aws-cloudfront/test/integ.cloudfront-cross-region-cert.js.snapshot/integ.json
diff --git a/...cert.js.snapshot/integcloudfrontcrossregionacmDefaultTestDeployAssertD48673AA.assets.json b/...cert.js.snapshot/integcloudfrontcrossregionacmDefaultTestDeployAssertD48673AA.assets.json
diff --git a/...teg/test/aws-cloudfront/test/integ.cloudfront-cross-region-cert.js.snapshot/manifest.json b/...teg/test/aws-cloudfront/test/integ.cloudfront-cross-region-cert.js.snapshot/manifest.json
diff --git a/.../asset.28a7d6256e60ec0ace46fa25cef1b24eaa625f4b65614aafc2c3c9a7a347c575/__entrypoint__.js b/.../asset.28a7d6256e60ec0ace46fa25cef1b24eaa625f4b65614aafc2c3c9a7a347c575/__entrypoint__.js
diff --git a/.../asset.9f60b80233926ffa4f6a0009e73d942e1f25b654dd0d24c710789aef082b96d0/__entrypoint__.js b/.../asset.9f60b80233926ffa4f6a0009e73d942e1f25b654dd0d24c710789aef082b96d0/__entrypoint__.js
diff --git a/...aa625f4b65614aafc2c3c9a7a347c575/index.js → ...1f25b654dd0d24c710789aef082b96d0/index.js b/...aa625f4b65614aafc2c3c9a7a347c575/index.js → ...1f25b654dd0d24c710789aef082b96d0/index.js
diff --git a/...integ/test/aws-cloudfront/test/integ.distribution-lambda-cross-region.js.snapshot/cdk.out b/...integ/test/aws-cloudfront/test/integ.distribution-lambda-cross-region.js.snapshot/cdk.out
diff --git a/...snapshot/cdkintegdistributionlambdacrossregionDefaultTestDeployAssert47F14485.assets.json b/...snapshot/cdkintegdistributionlambdacrossregionDefaultTestDeployAssert47F14485.assets.json
diff --git a/...gion.js.snapshot/edge-lambda-stack-c8363f8375cbe20a55dbe2aafe5dcee3889b0631e6.assets.json b/...gion.js.snapshot/edge-lambda-stack-c8363f8375cbe20a55dbe2aafe5dcee3889b0631e6.assets.json
diff --git a/...eg.distribution-lambda-cross-region.js.snapshot/edge-lambda-stack-eu-west-1-2.assets.json b/...eg.distribution-lambda-cross-region.js.snapshot/edge-lambda-stack-eu-west-1-2.assets.json
diff --git a/...bution-lambda-cross-region.js.snapshot/integ-distribution-lambda-cross-region.assets.json b/...bution-lambda-cross-region.js.snapshot/integ-distribution-lambda-cross-region.assets.json
diff --git a/...tion-lambda-cross-region.js.snapshot/integ-distribution-lambda-cross-region.template.json b/...tion-lambda-cross-region.js.snapshot/integ-distribution-lambda-cross-region.template.json
@@ -73,7 +73,7 @@
      "S3Bucket": {
       "Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-eu-west-1"
      },
-     "S3Key": "28a7d6256e60ec0ace46fa25cef1b24eaa625f4b65614aafc2c3c9a7a347c575.zip"
+     "S3Key": "9f60b80233926ffa4f6a0009e73d942e1f25b654dd0d24c710789aef082b96d0.zip"
     },
     "Timeout": 900,
     "MemorySize": 128,

diff --git a/...eg/test/aws-cloudfront/test/integ.distribution-lambda-cross-region.js.snapshot/integ.json b/...eg/test/aws-cloudfront/test/integ.distribution-lambda-cross-region.js.snapshot/integ.json
diff --git a/...test/aws-cloudfront/test/integ.distribution-lambda-cross-region.js.snapshot/manifest.json b/...test/aws-cloudfront/test/integ.distribution-lambda-cross-region.js.snapshot/manifest.json
diff --git a/...teg/test/aws-cloudfront/test/integ.distribution-lambda-cross-region.js.snapshot/tree.json b/...teg/test/aws-cloudfront/test/integ.distribution-lambda-cross-region.js.snapshot/tree.json
diff --git a/...t/integ.lambda-alarm-action.js.snapshot/LambdaAlarmActionIntegrationTestStack.assets.json b/...t/integ.lambda-alarm-action.js.snapshot/LambdaAlarmActionIntegrationTestStack.assets.json