improve const correctness and make elide detection more robust

daschuer · Sep 20, 2024 · dd55dae · dd55dae
1 parent 7f5711c
commit dd55dae
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/library/dlgtagfetcher.cpp b/src/library/dlgtagfetcher.cpp
@@ -537,14 +537,14 @@ void DlgTagFetcher::slotNetworkResult(
         const QString& app,
         const QString& message,
         int code) {
-    QString cantConnect = tr("Can't connect to %1: %2").arg(app, message);
-    QFontMetrics metrics(loadingProgressBar->font());
-    QString elidedCantConnect = metrics.elidedText(
+    const QString cantConnect = tr("Can't connect to %1: %2").arg(app, message);
+    const QFontMetrics metrics(loadingProgressBar->font());
+    const QString elidedCantConnect = metrics.elidedText(
             cantConnect,
             Qt::ElideRight,
             loadingProgressBar->width() - 4);
     loadingProgressBar->setFormat(elidedCantConnect);
-    if (cantConnect.size() != elidedCantConnect.size()) {
+    if (cantConnect != elidedCantConnect) {
         loadingProgressBar->setToolTip(cantConnect);
     }
     qWarning() << "Error while fetching track metadata!"