Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto dj crates #1

Merged
merged 32 commits into from
Jun 24, 2013
Merged

Auto dj crates #1

merged 32 commits into from
Jun 24, 2013

Conversation

ulatekh
Copy link

@ulatekh ulatekh commented Jun 22, 2013

My fixes, per the discussion at mixxxdj#18 .

daschuer and others added 30 commits May 17, 2013 00:46
Remove CO* constructor to COT. Cleanups.
…S X API for looking up byte order instead of hardcoding.
… causing PPC MP3/M4A issues. Convert tabs to spaces.
daschuer added a commit that referenced this pull request Jun 24, 2013
@daschuer daschuer merged commit 5f63af5 into daschuer:auto-dj-crates Jun 24, 2013
daschuer pushed a commit that referenced this pull request Oct 10, 2013
daschuer pushed a commit that referenced this pull request Jul 20, 2014
replace memmove with direct assignments, saves ~ 10 % CPU time
daschuer pushed a commit that referenced this pull request Oct 5, 2014
daschuer pushed a commit that referenced this pull request Nov 5, 2014
daschuer pushed a commit that referenced this pull request May 11, 2015
Introduced a EngineFilterPan class
Thank you very much, i'll try to integrate it fastly :)
daschuer pushed a commit that referenced this pull request Jun 25, 2015
daschuer pushed a commit that referenced this pull request Aug 5, 2015
…eeded to control the graphic eq effect. This commit adds this feature for effect# 2&3 (was only for effect #1). Missed that in 14dcadd
daschuer pushed a commit that referenced this pull request Sep 3, 2015
Merged SoundNetworkDevice to integrate shoutcast work better for future use
daschuer pushed a commit that referenced this pull request Sep 8, 2015
Deere: Fix styling for selected Treeview items
@daschuer daschuer mentioned this pull request Jul 10, 2016
daschuer pushed a commit that referenced this pull request Aug 31, 2016
daschuer pushed a commit that referenced this pull request Jun 3, 2017
reduce loading time: pack Decks & Mixer into Singleton
daschuer pushed a commit that referenced this pull request Dec 27, 2017
Tremolo Depth parameter
daschuer pushed a commit that referenced this pull request Apr 17, 2018
update Tango skin, adapt to Library redesign
daschuer pushed a commit that referenced this pull request Dec 2, 2018
daschuer pushed a commit that referenced this pull request Jan 21, 2020
daschuer pushed a commit that referenced this pull request Jun 15, 2020
…vision

Hercules DJControl Jogvision: Fix eslint issues
daschuer pushed a commit that referenced this pull request Feb 1, 2021
Pioneer DDJ-400: Merge 2.2 branch and fix some eslint issues
daschuer pushed a commit that referenced this pull request Mar 16, 2022
…h sync

When loading a track that is not yet present in the library (and thus
doesn't have any BPM because it hasn't been analyzed yet) while another
deck is playing and both decks have sync enabled, a debug assertion is
triggered:

    DEBUG ASSERT: "isValid()" in function double mixxx::Bpm::value() const at src/track/bpm.h:53
    Aborted (core dumped)

The backtrace looks as follows:

    #0  0x00007f175c87234c in __pthread_kill_implementation () at /usr/lib/libc.so.6
    #1  0x00007f175c8254b8 in raise () at /usr/lib/libc.so.6
    #2  0x00007f175c80f534 in abort () at /usr/lib/libc.so.6
    #3  0x00007f175cf05ee4 in qt_assert(char const*, char const*, int) () at /usr/lib/libQt5Core.so.5
    #4  0x000055deb2e67e1c in mixxx::(anonymous namespace)::handleMessage(QtMsgType, QMessageLogContext const&, QString const&) (type=<optimized out>, context=<optimized out>, input=<optimized out>) at src/util/logging.cpp:355
    #5  0x00007f175cf47128 in  () at /usr/lib/libQt5Core.so.5
    #6  0x00007f175cf3fd8a in  () at /usr/lib/libQt5Core.so.5
    #7  0x00007f175cf06526 in QMessageLogger::critical(char const*, ...) const () at /usr/lib/libQt5Core.so.5
    #8  0x000055deb2e5c720 in mixxx_debug_assert(char const*, char const*, int, char const*) (assertion=assertion@entry=0x55deb39bd0db "isValid()", file=file@entry=0x55deb39bbf30 "src/track/bpm.h", line=line@entry=53, function=function@entry=0x55deb39bbf08 "double mixxx::Bpm::value() const") at gsrc/util/assert.h:9
    #9  0x000055deb2ee7e7e in mixxx_debug_assert_return_true(char const*, char const*, int, char const*) (function=0x55deb39bbf08 "double mixxx::Bpm::value() const", line=53, file=0x55deb39bbf30 "src/track/bpm.h", assertion=0x55deb39bd0db "isValid()") at gsrc/util/assert.h:18
    #10 mixxx::Bpm::value() const (this=<synthetic pointer>) at src/track/bpm.h:53
    #11 mixxx::operator*(mixxx::Bpm, double) (multiple=1, bpm=...) at src/track/bpm.h:160
    #12 SyncControl::setLocalBpm(mixxx::Bpm) (this=<optimized out>, localBpm=...) at src/engine/sync/synccontrol.cpp:567
    #13 0x000055deb34c7ba3 in EngineBuffer::postProcess(int) (this=0x55deb56eb060, iBufferSize=2048) at src/engine/enginebuffer.cpp:1318
    #14 0x000055deb3139023 in EngineMaster::processChannels(int) (this=0x55deb5449440, iBufferSize=<optimized out>) at src/engine/enginemaster.cpp:383
    #15 0x000055deb31394f7 in EngineMaster::process(int) (this=0x55deb5449440, iBufferSize=iBufferSize@entry=2048) at src/engine/enginemaster.cpp:410
    #16 0x000055deb2f91d0b in SoundManager::onDeviceOutputCallback(long) (this=<optimized out>, iFramesPerBuffer=iFramesPerBuffer@entry=1024) at src/soundio/soundmanager.cpp:596
    #17 0x000055deb32dd794 in SoundDevicePortAudio::callbackProcessClkRef(long, float*, float const*, PaStreamCallbackTimeInfo const*, unsigned long) (this=0x55deb553e6b0, framesPerBuffer=1024, out=<optimized out>, in=<optimized out>, timeInfo=<optimized out>, statusFlags=<optimized out>) at src/soundio/sounddeviceportaudio.cpp:965

This happens because `newLocalBpm` is invalid when `localBpm` is
invalid. Trying to do sync decks while no tempo information is available
does not make sense, so we only synchronize decks if the local BPM is
available.
daschuer pushed a commit that referenced this pull request Sep 29, 2022
Shade: Put all VU meters in a fixed size parent widget
daschuer pushed a commit that referenced this pull request Dec 10, 2023
Reformatted code to modern ES6 class structure
daschuer pushed a commit that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants