Add HistoryFeature actions in a parented_ptr

src/library/features/history/historyfeature.cpp

@@ -19,12 +19,12 @@ HistoryFeature::HistoryFeature(UserSettingsPointer pConfig,
                              TrackCollection* pTrackCollection)
         : BasePlaylistFeature(pConfig, pLibrary, parent, pTrackCollection),
           m_playlistId(-1) {
-    m_pJoinWithNextAction = new QAction(tr("Join with next"), this);
-    connect(m_pJoinWithNextAction, SIGNAL(triggered()),
+    m_pJoinWithNextAction = make_parented<QAction>(tr("Join with next"), this);
+    connect(m_pJoinWithNextAction.get(), SIGNAL(triggered()),
             this, SLOT(slotJoinWithNext()));
 
-    m_pGetNewPlaylist = new QAction(tr("Create new history playlist"), this);
-    connect(m_pGetNewPlaylist, SIGNAL(triggered()), this, SLOT(slotGetNewPlaylist()));
+    m_pGetNewPlaylist = make_parented<QAction>(tr("Create new history playlist"), this);
+    connect(m_pGetNewPlaylist.get(), SIGNAL(triggered()), this, SLOT(slotGetNewPlaylist()));
 
     // initialized in a new generic slot(get new history playlist purpose)
     emit(slotGetNewPlaylist());
@@ -95,15 +95,15 @@ void HistoryFeature::onRightClickChild(const QPoint& globalPos, const QModelInde
     menu.addAction(m_pAddToAutoDJAction);
     menu.addAction(m_pAddToAutoDJTopAction);
     menu.addAction(m_pRenamePlaylistAction);
-    menu.addAction(m_pJoinWithNextAction);
+    menu.addAction(m_pJoinWithNextAction.get());
     if (playlistId != m_playlistId) {
         // Todays playlist should not be locked or deleted
         menu.addAction(m_pDeletePlaylistAction);
         menu.addAction(m_pLockPlaylistAction);
     }
     if (playlistId == m_playlistId && m_playlistDao.tracksInPlaylist(m_playlistId) != 0) {
         // Todays playlists can change !
-        menu.addAction(m_pGetNewPlaylist);
+        menu.addAction(m_pGetNewPlaylist.get());
     }
     menu.addSeparator();
     menu.addAction(m_pExportPlaylistAction);

src/library/features/history/historyfeature.h

@@ -54,8 +54,8 @@ class HistoryFeature : public BasePlaylistFeature {
 
     QPointer<WLibrarySidebar> m_pSidebar;
     QLinkedList<TrackId> m_recentTracks;
-    QAction* m_pJoinWithNextAction;
-    QAction* m_pGetNewPlaylist;
+    parented_ptr<QAction> m_pJoinWithNextAction;
+    parented_ptr<QAction> m_pGetNewPlaylist;
     std::unique_ptr<HistoryTreeModel> m_pHistoryTreeModel;
     int m_playlistId;
 };