14 flags #18
Closed
14 flags #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1a35f98.
Should allow for --root= or --root to work
Can't pass arbitrary args, need to use os.args Check for the = in the arg for the root dir
|
Can't use the flag library. Doesn't allow for arbitrary args. But if we add the case for the --root= works fine. Without that case the arg is parsed all as one value instead of splitting on --root and the file path. So we have to take it and split on the = sign. Also reworked the default cwd handling. Managed to shrink the code down a bit. |
|
I guess we don't need this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the flag library to handle parsing the args. Gave it a quick test and it appears to work regardless of the = or no =
This is a fix for #14
It also works with the bin-dir branch too.