[featureflag] expose feature flag API via frontend #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * propagate the change from bool to float introduced in open-telemetry#1237 more consistently via proto definitions by differentiating between the GetFlag operation (which evaluates the probabilty and therefore returns a bool) and all other operations, which need to operate with a float value/probability directly. To that end, the Flag grpc message has been split into two new types, FlagEvaluationResult and FlagDefinition. * Rename the UpdateFlag operation to UpdateFlagProbability, as it actually only updates the enabled/probability value, but not the description or the name.
basti1302
force-pushed
the
expose-feature-flag-api
branch
from
45ad1bc
to
3c7c5d7
Compare
basti1302
commented
Jan 29, 2024
| @@ -15,7 +15,7 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
There was a problem hiding this comment.
All go code in this PR is autogenerated, no manual change here. Also, non of the Go services relied on the GRPC interfaces that have been changed, so these services should not be affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to do things like this for the ad service, the product catalog service, and the cart service.
which would set the failure rate of the Ad service to 20%.
Also:
[featureflag]: use float to check for flag probability open-telemetry/opentelemetry-demo#1237
more consistently via proto definitions by differentiating between
the GetFlag operation (which evaluates the probabilty and therefore
returns a bool) and all other operations, which need to operate with
a float value/probability directly. To that end, the Flag grpc
message has been split into two new types, FlagEvaluationResult
and FlagDefinition.
actually only updates the enabled/probability value, but not the
description or the name.