fix: increase reliability of validation by wrapping Node.js spawned processes in SH #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To curb the sprawling amount of old and outdated version of some collector distributions, and to be able to deal with incompatible ones cleanly, this commit introduces support for semver ranges of ignored versions.
Node.js spawn is unreliable in terms of collecting stdout and stderr through the spawn call (see nodejs/node#19218). Getting a shell around the otelcol binary increases the reliability.
|
@mmanciop is attempting to deploy a commit to the OTelBin Team on Vercel. To accomplish this, @mmanciop needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
|
Opps wrong repo, wanted to open it in my fork first :-) Closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js
spawnandspawnAsyncAPIs seem rather unreliable in terms of collectingstdoutandstderrthat occurs close to spawned process terminating (see, e.g., nodejs/node#19218). We need thestderrof processes terminating with status code>1to understand which validation error occurred. This PR increases the resilience of accessing thestderroutput by wrapping anshshell around the invocation of the otelcol binary.