Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value of "received options" in error message #128

Merged
merged 1 commit into from
May 25, 2024

Conversation

c4710n
Copy link
Contributor

@c4710n c4710n commented May 23, 2024

This PR aims to close #127.

  • In order to get the original opts when composing the error message, I extended the second argument of reduce_options/2.
  • There is also a trivial modification that unifies the function signatures of validate_unknown_options/2 and validate_options/2.

I am not very confident in the elegance of this code; comments are welcome, and I am happy to make revisions.

@coveralls
Copy link

Pull Request Test Coverage Report for Build d725b0bd19d95a07db55f812c3e065ecb7105911-PR-128

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.0%

Totals Coverage Status
Change from base Build a3acae8e316935696d50e59140454f9cc20402b6: 0.0%
Covered Lines: 279
Relevant Lines: 300

💛 - Coveralls

@whatyouhide whatyouhide merged commit 4e34df1 into dashbitco:main May 25, 2024
2 checks passed
@whatyouhide
Copy link
Collaborator

Thank you @c4710n 💟

@c4710n
Copy link
Contributor Author

c4710n commented May 25, 2024

My pleasure!

@c4710n c4710n deleted the zd/fix-received-options branch May 25, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A question on error message of validate/2
3 participants