m4/boost.m4: fix rpath option check for static linking #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When statically linking, the order in which -l options are passed is important. The contents of the LIBS option passed to the configure environment should be passed *after* other -l options used internally by the package. For example, libboost_program_options may used symbols from the libatomic library, and in this case, one need to pass LIBS="-latomic" to cc-tool's configure script. When using dynamic linking, this works fine, because the rpath test does "-latomic -lboost_program_options". However, when statically linking, this doesn't work because libboost_program_options uses symbols from libatomic, so -latomic must be passed *after* -lboost_program_options. Therefore, this commit inverts the list of variables used to construct LIBS before doing the _BOOST_AC_LINK_IFELSE() test detecting the rpath option to be used. Indeed, $boost_save_LIBS contains the previously saved LIBS variable, and should be passed after $Boost_lib_LIBS. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> [Retrieved from: https://git.buildroot.net/buildroot/tree/package/cc-tool/0004-m4-boost.m4-fix-rpath-option-check-for-static-linkin.patch] Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When statically linking, the order in which -l options are passed is
important. The contents of the LIBS option passed to the configure
environment should be passed after other -l options used internally
by the package.
For example, libboost_program_options may used symbols from the
libatomic library, and in this case, one need to pass LIBS="-latomic"
to cc-tool's configure script. When using dynamic linking, this works
fine, because the rpath test does "-latomic
-lboost_program_options". However, when statically linking, this
doesn't work because libboost_program_options uses symbols from
libatomic, so -latomic must be passed after -lboost_program_options.
Therefore, this commit inverts the list of variables used to construct
LIBS before doing the _BOOST_AC_LINK_IFELSE() test detecting the rpath
option to be used. Indeed, $boost_save_LIBS contains the previously
saved LIBS variable, and should be passed after $Boost_lib_LIBS.
Signed-off-by: Thomas Petazzoni thomas.petazzoni@free-electrons.com
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/cc-tool/0004-m4-boost.m4-fix-rpath-option-check-for-static-linkin.patch]
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com