Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: throw correct RPC error on invalid params #252

Merged
merged 3 commits into from
Mar 17, 2020
Merged

fix: throw correct RPC error on invalid params #252

merged 3 commits into from
Mar 17, 2020

Conversation

shuplenkov
Copy link
Member

No description provided.

@shuplenkov shuplenkov changed the base branch from v0.10-dev to master March 16, 2020 16:37
shumkov
shumkov suggested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check that we handle coreApi and insightApi errors correctly with functional tests.

shuplenkov added 2 commits March 17, 2020 17:50
shumkov
shumkov approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@shumkov shumkov merged commit 52b1276 into master Mar 17, 2020
@shumkov shumkov deleted the rpc-error-if-not-found branch March 17, 2020 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

@jawid-h jawid-h Awaiting requested review from jawid-h

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov