This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
fix!: invalid JSON RPC internal error code #271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Updated return error code according to a spec here
What was done?
Updated return error code to a
-32603
for internal errorsHow Has This Been Tested?
Tested using running
mn-bootstrap
using custom pre-builtdapi
image. And checking error code returned by thedapi-client
Breaking Changes
Error code for internal errors now
-32603
, as per spec.Checklist:
For repository code-owners and collaborators only