Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: replace broadcast_tx_commit with broadcast_tx_async #330

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Jan 6, 2021

Issue being fixed or feature implemented

broadcast_tx_commit should be used only for debug and development purposes.

What was done?

Replaced broadcast_tx_commit with broadcast_tx_async

How Has This Been Tested?

Tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.18 milestone Jan 6, 2021
@shuplenkov shuplenkov requested review from shumkov and antouhou January 6, 2021 13:13
antouhou
antouhou previously approved these changes Jan 6, 2021
shumkov
shumkov previously approved these changes Jan 7, 2021
feat: login to docker in travis script
@shuplenkov shuplenkov dismissed stale reviews from shumkov and antouhou via ad8ccc0 January 11, 2021 15:30
@shumkov shumkov changed the title feat: replace broadcast_tx_commit with broadcast_tx_async feat: replace broadcast_tx_commit with broadcast_tx_async Jan 20, 2021
@shumkov shumkov merged commit d704cf4 into v0.18-dev Jan 20, 2021
@shumkov shumkov deleted the broadcast_tx_async branch January 20, 2021 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants