This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
feat!: convenient broadcast errors #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuplenkov
approved these changes
Sep 20, 2021
shumkov
changed the title
antouhou
pushed a commit
that referenced
this pull request
Oct 25, 2021
Co-authored-by: Konstantin Shuplenkov <konstantin.shuplenkov@dash.org>
antouhou
pushed a commit
that referenced
this pull request
Oct 25, 2021
Co-authored-by: Konstantin Shuplenkov <konstantin.shuplenkov@dash.org>
antouhou
pushed a commit
that referenced
this pull request
Oct 26, 2021
Co-authored-by: Konstantin Shuplenkov <konstantin.shuplenkov@dash.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Provide detailed error information for the broadcast state transition method, including DAPI/Drive common errors and DPP consensus errors.
What was done?
StateTransitionBroadcastErrorin case if local basic validation failedStateTransitionBroadcastErrorHow Has This Been Tested?
With tests
Breaking Changes
StateTransitionBroadcastError#getDatais removed. UseStateTransitionBroadcastError#getCauseto get additional details.Checklist:
For repository code-owners and collaborators only