Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

fix: UTXO selection doesn't work properly #277

Merged
merged 15 commits into from
Oct 5, 2021
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Oct 4, 2021

Issue being fixed or feature implemented

There are several UTXO related bugs:

  • Transaction is rejected: tx-txlock-conflict
  • Not enough balance (0) to cover burn amount of 5
  • utxosList must contain at least 1 utxo

Also, Due to a bug in grpc-js explained here. A temporary solution is used to bypass this bug until a fix is merged into Node.js explained here

Need to update DAPI Client to fix the bug with DAPI Client browser compatibility dashevo/js-dapi-client#284

What was done?

  • Update DAPI Client
  • Update Wallet

How Has This Been Tested?

With CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h closed this Oct 5, 2021
@jawid-h jawid-h reopened this Oct 5, 2021
@shumkov shumkov added this to the v0.21.0 milestone Oct 5, 2021
@jawid-h jawid-h marked this pull request as ready for review October 5, 2021 17:22
@shumkov shumkov merged commit a653814 into v0.21-dev Oct 5, 2021
@shumkov shumkov deleted the fix-utxo-select branch October 5, 2021 17:23
antouhou pushed a commit that referenced this pull request Oct 25, 2021
Co-authored-by: Konstantin Shuplenkov <konstantin.shuplenkov@dash.org>
Co-authored-by: Alex Werner <Alex-Werner@users.noreply.github.com>
Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com>
antouhou pushed a commit that referenced this pull request Oct 25, 2021
Co-authored-by: Konstantin Shuplenkov <konstantin.shuplenkov@dash.org>
Co-authored-by: Alex Werner <Alex-Werner@users.noreply.github.com>
Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com>
antouhou pushed a commit that referenced this pull request Oct 26, 2021
Co-authored-by: Konstantin Shuplenkov <konstantin.shuplenkov@dash.org>
Co-authored-by: Alex Werner <Alex-Werner@users.noreply.github.com>
Co-authored-by: Djavid Gabibiyan <djavidoff@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants