Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Commit

Permalink
feat: use gRPC error codes for ABCI
Browse files Browse the repository at this point in the history
  • Loading branch information
Konstantin Shuplenkov committed Sep 1, 2021
1 parent 9ef9f74 commit f04bed6
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const InvalidStateTransitionError = require('@dashevo/dpp/lib/stateTransition/errors/InvalidStateTransitionError');
const BalanceIsNotEnoughError = require('@dashevo/dpp/lib/errors/BalanceIsNotEnoughError');
const BalanceIsNotEnoughError = require('@dashevo/dpp/lib/errors/consensus/fee/BalanceIsNotEnoughError');

const InvalidArgumentGrpcError = require('@dashevo/grpc-common/lib/server/error/InvalidArgumentGrpcError');
const ResourceExhaustedGrpcError = require('@dashevo/grpc-common/lib/server/error/ResourceExhaustedGrpcError');
Expand Down
5 changes: 2 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@dashevo/dashcore-lib": "~0.19.25",
"@dashevo/dashd-rpc": "^2.3.0",
"@dashevo/dashd-zmq": "^1.2.0",
"@dashevo/dpp": "~0.21.0-dev.3",
"@dashevo/dpp": "github:dashevo/js-dpp#error-necessary-data",
"@dashevo/feature-flags-contract": "~0.2.0",
"@dashevo/grpc-common": "~0.4.0",
"@dashevo/merk": "git+https://github.com/dashevo/node-merk.git",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const getIdentityCreateTransitionFixture = require('@dashevo/dpp/lib/test/fixtures/getIdentityCreateTransitionFixture');

const ConsensusError = require('@dashevo/dpp/lib/errors/ConsensusError');
const InvalidStateTransitionTypeError = require('@dashevo/dpp/lib/errors/consensus/basic/stateTransition/InvalidStateTransitionTypeError');
const InvalidStateTransitionError = require('@dashevo/dpp/lib/stateTransition/errors/InvalidStateTransitionError');
const BalanceNotEnoughError = require('@dashevo/dpp/lib/errors/BalanceIsNotEnoughError');
const BalanceNotEnoughError = require('@dashevo/dpp/lib/errors/consensus/fee/BalanceIsNotEnoughError');
const ValidatorResult = require('@dashevo/dpp/lib/validation/ValidationResult');

const InvalidArgumentGrpcError = require('@dashevo/grpc-common/lib/server/error/InvalidArgumentGrpcError');
Expand Down Expand Up @@ -51,9 +51,9 @@ describe('unserializeStateTransitionFactory', () => {
});

it('should throw InvalidArgumentAbciError if State Transition is invalid', async () => {
const consensusError = new ConsensusError('Invalid state transition');
const dppError = new InvalidStateTransitionTypeError(-1);
const error = new InvalidStateTransitionError(
[consensusError],
[dppError],
stateTransitionFixture,
);

Expand All @@ -68,7 +68,7 @@ describe('unserializeStateTransitionFactory', () => {
expect(e.getMessage()).to.equal('State Transition is invalid');
expect(e.getCode()).to.equal(GrpcErrorCodes.INVALID_ARGUMENT);
expect(e.getRawMetadata()).to.deep.equal({
errors: [consensusError],
errors: [dppError],
});

expect(dppMock.stateTransition.createFromBuffer).to.be.calledOnce();
Expand Down

0 comments on commit f04bed6

Please sign in to comment.