This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
fix: comportement on new address with existing transaction in store #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
When we import a transaction and one of it's constitutive element (input or output) impact and address that we own but are not yet aware of it (because it exceed the BIP44 spec on first run, for instance on an index 21).
We will submit for insertion again, but we where preventing any processing as we already had it.
This PR fixes that issue.
What was done?
How Has This Been Tested?
This specific case (us paying to ourself with a gap of address) were not included in test and will require to add it in our Tests improvement PR coming soon.
Breaking Changes
None.
Checklist: