Skip to content
This repository has been archived by the owner on Jan 12, 2022. It is now read-only.

feat: add patched Console transport for winston to make it work in the browser #330

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

antouhou
Copy link
Contributor

@antouhou antouhou commented Oct 8, 2021

Issue being fixed or feature implemented

Winston logger not working in a browser

What was done?

Copypasted default winston transport and changed setImmediate(fn) to setTimeout(fn, 1)

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou added this to the v0.21.0 milestone Oct 8, 2021
shuplenkov
shuplenkov previously approved these changes Oct 8, 2021
shumkov
shumkov previously approved these changes Oct 8, 2021
@antouhou antouhou dismissed stale reviews from shumkov and shuplenkov via cec479a October 8, 2021 14:11
shumkov
shumkov previously approved these changes Oct 8, 2021
@shuplenkov shuplenkov requested a review from shumkov October 8, 2021 16:00
Copy link
Contributor

@Alex-Werner Alex-Werner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's clear that Google and Firefox are reluctant for setImmediate and invite devs to implement a polyfill, so let's polyfill it !

@antouhou antouhou merged commit c65ca62 into v0.21-dev Oct 11, 2021
@antouhou antouhou deleted the feat-winston-cross-platform-console branch October 11, 2021 11:10
shuplenkov pushed a commit that referenced this pull request Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants