Skip to content

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Oct 14, 2025

Additional Information

  • This change is a counterpart to 8f43302 from bitcoin#28461

  • Required to resolve build failures using Guix (see below) when paired with dash#6889

    Build failure:
    x86_64-w64-mingw32-ld: /gnu/store/jiiy3vkhajmi1lyxcvq5x3l82i6f9agf-gcc-cross-x86_64-w64-mingw32-12.4.0-lib/x86_64-w64-mingw32/lib/../lib/libssp.a(ssp.o):(.text+0xf0): multiple definition of `__stack_chk_fail'; /gnu/store/jiiy3vkhajmi1lyxcvq5x3l82i6f9agf-gcc-cross-x86_64-w64-mingw32-12.4.0-lib/x86_64-w64-mingw32/lib/../lib/libssp.dll.a(libssp_0_dll_d000007.o):(.text+0x0): first defined here
      CXX      masternode/libbitcoin_node_a-sync.o
      CXX      masternode/libbitcoin_node_a-utils.o
      CXX      node/libbitcoin_node_a-blockstorage.o
    collect2: error: ld returned 1 exit status
    make[3]: *** [Makefile:3247: runtest.exe] Error 1
    make[3]: Leaving directory '/distsrc-base/distsrc-23.0.0-rc.1-8-g32ad4a7b3885-x86_64-w64-mingw32/src/dashbls'
    make[2]: *** [Makefile:23826: dashbls/libdashbls.la] Error 2
    make[2]: *** Waiting for unfinished jobs....
    make[2]: Leaving directory '/distsrc-base/distsrc-23.0.0-rc.1-8-g32ad4a7b3885-x86_64-w64-mingw32/src'
    make[1]: *** [Makefile:21421: all-recursive] Error 1
    make[1]: Leaving directory '/distsrc-base/distsrc-23.0.0-rc.1-8-g32ad4a7b3885-x86_64-w64-mingw32/src'
    make: *** [Makefile:793: all-recursive] Error 1
    

Counterpart to 8f43302a0a from bitcoin#28461
@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PastaPastaPasta PastaPastaPasta merged commit 3a2208e into dashpay:develop Oct 14, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants