-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rid of UB and memory leak based on clang warnings #67
Conversation
It also resolves clang's warning
I think this should be done upstream |
'This PR has been flagged as stale due to no activity for over 60 |
@PastaPastaPasta that 2 PR are dead in Chia's repo. Can you review and merge this PR instead waiting them get merged and backported later? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for squash merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should backport Chia-Network#370 and Chia-Network#371
superseded by #83 |
final
and virtual destructor to avoid memory leak.It also removes several clang's warnings during build.