fix: various fixes for "Build and test library" action #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
fix_macos_test_build
branch
from
9c63388 to
738d187
Compare
UdjinM6
changed the title
UdjinM6
force-pushed
the
fix_macos_test_build
branch
4 times, most recently
from
f713ec9 to
738d187
Compare
|
NOTE: Go bindings are still broken. This is expected and out of the scope for this PR. |
kwvg
approved these changes
Sep 26, 2024
5 tasks
knst
reviewed
Oct 4, 2024
| # in expected paths because they may conflict with system files. Ask | ||
| # Homebrew where each one is located, then adjust paths accordingly. | ||
| gmp_prefix=`$BREW --prefix gmp 2>/dev/null` | ||
| if test x$gmp_prefix != x; then |
There was a problem hiding this comment.
better to have "" around variables, such as if test "x$gmp_prefix" != x; then but that's moved code, so let it be as it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.