Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashmate quick update #660

Open
wants to merge 2 commits into
base: v1.0-dev
Choose a base branch
from
Open

Dashmate quick update #660

wants to merge 2 commits into from

Conversation

ktechmidas
Copy link
Contributor

Issue being fixed or feature implemented

This will run a quick update if you set the var, only set the var if the network is already deployed and just needs updating

What was done?

Added var for dashmate_quick_update and quick_update.yml with the basics

How Has This Been Tested?

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of code duplication. It will be hard to maintain so you need to change same things in both places. I didn't get what is the actual difference. Also I think tags a more appropriate in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants