4 translations issues

[akijuh]

1. Encrypt window buttons are not translated.

2. Encrypt confirmation window buttons are not translated.

3. Change password window buttons are not translated.

4. Unlock wallet window buttons are not translated.

5. About QT window info text is not translated.

6. Request payment window InstantSend "Yes/no" info text is not translated.

[UdjinM6]

1-4, 6 - should be fixed
5 - we do not have control over "about qt", it's a standard one

[akijuh]

Ok, closing.

[akijuh]

@UdjinM6 reopened this.

v0.12.2.0-52cd4d4 (10.10.2017) translations issues

1. Encrypt window -> 'Cancel' button is not translated.
2. Encrypt confirmation window -> 'Yes' and 'Cancel' button is not translated.
3. Change password window -> 'Cancel' button is not translated.
4. Unlock wallet window -> 'Cancel' button is not translated.

[UdjinM6]

Can't confirm any of it, all looks good for me (Russian, macos).

[akijuh]

Windows 7 x64, screenshots as proof.

Encrypt window

Encrypt confirmation window

Change password window

Unlock wallet window

[akijuh]

@UdjinM6 I figured it out, i think.

My windows is english version, i think that is the reason for this, do you confirm?

[UdjinM6]

Hmmm, this shouldn't be the case. It's really weird. I can actually confirm that bamboo binaries have this issue, but I have no such issue with my local build. I'll rebuild local binaries from scratch once again, though I'm pretty sure I already did this AFTER translations were merged, but maybe I'm wrong...

@schinzelh could there be some issues with bamboo cache or smth like that?

[schinzelh]

Hmm, git source shouldn’t be cached durin gitian builds - plus version number contains git commit hash. Do the localization bundles get statically compiled in, or do they end up in some system specific qt datapath? What happens if this path gets cleared on the system?

[UdjinM6]

Hmm... In my local build About Qt text is also translated and it's not the case for the bamboo build.


So the issue is not about our localization files imo, it's about qt. Looks like there were quite few updates in depends/ for qt in bitcoin core...