Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Send tab -> Subtract fee check box #805

Closed
akijuh opened this issue May 24, 2016 · 1 comment
Closed

[GUI] Send tab -> Subtract fee check box #805

akijuh opened this issue May 24, 2016 · 1 comment

Comments

@akijuh
Copy link

akijuh commented May 24, 2016

Win7 64bit - v0.12.1.0-16671cd

Send tab -> Subtract fee check box need some space to left side.

subtract
@crowning-
Copy link

Tagged, will check later this week.

@UdjinM6 UdjinM6 mentioned this issue Jun 6, 2016
Merged
@akijuh akijuh closed this as completed Jun 6, 2016
knst pushed a commit to knst/dash that referenced this issue Jul 13, 2024
@hebasto
Merge bitcoin-core/gui#806: refactor: Misc int sign change fixes
aaab5fb 
0541642 refactor: Avoid implicit-integer-sign-change in processNewTransaction (MarcoFalke)
321f105 refactor: Avoid implicit-signed-integer-truncation-or-sign-change in FreedesktopImage (MarcoFalke)
6d8eecd refactor: Avoid implicit-integer-sign-change in createTransaction (MarcoFalke)

Pull request description:

  This is allowed by the language. However, the `integer` sanitizer complains about it. Thus, fix it, so that the `integer` sanitizer can be used in the future to catch unintended sign changes.

  Fixes dashpay#805.

ACKs for top commit:
  pablomartin4btc:
    tACK 0541642
  hebasto:
    ACK 0541642, I have reviewed the code and it looks OK.

Tree-SHA512: eaa941479bd7bee196eb8b31d93b8e1db122410cf62e8ec4cbbec35cfd14cc766081c3df5dd14a228e21ad2678d8b8ba0d2649e5934c994a90ae96d8b264b4ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akijuh @crowning-