"path" argument isn't used in masternode conf read function #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkcoinproject
added a commit
that referenced
this pull request
Jan 12, 2015
"path" argument isn't used in masternode conf read function
|
Good find |
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
Update accumulator checkpoints for 3.1.0
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 4, 2024
7e747e8a07 Merge pull request dashpay#105 from kwvg/bump_1.3.4 f8703c9971 chore: bump version to 1.3.4 5cc55ce222 Merge pull request dashpay#104 from UdjinM6/fix_gmp_freebsd aad89e3e86 Merge pull request dashpay#103 from kwvg/pyci_upd a52d7ed109 Merge pull request dashpay#102 from kwvg/autoconf 56b2d4a0ac ci: replace EoL Go 1.17 with 1.22 17f3ab47a0 ci: drop EoL Python 3.7 and 3.8, replace with Python 3.12 a3fcdde7c5 fix: gmp detection on FreeBSD e73acdd304 build: consolidate `TARGET_OS` assignments into `OPSYS` assignment case 343c6244ac build: remove unnecessary `BUILD_`{`BENCH`, `TEST`} variables af9a6906c3 build: account for FreeBSD's `amd64` `host_cpu` in optim. CPU detection 34a7c60e86 build: replace `bash`-isms with `sh`-friendly `test` and `case` git-subtree-dir: src/dashbls git-subtree-split: 7e747e8a0769f6e4d308d8d2e3dd254c240cbdd9
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Dec 5, 2024
30aa085b2b fixup: apply code review comments a3afed8669 refactor: continued reduced duplication 0f3705b7db simplify G1Element::Serialize by using G1Element::SerializeToArray 677db58fc3 add SerializeToArray for PrivateKey d1b3d244f0 fixup add const 09ac2e90d5 feat: implement std::array based serialization REVERT: 7e747e8a07 Merge pull request dashpay#105 from kwvg/bump_1.3.4 REVERT: f8703c9971 chore: bump version to 1.3.4 git-subtree-dir: src/dashbls git-subtree-split: 30aa085b2b8a169c157d3dfcba2caf604e8d3e54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of possible solutions (which is implemented in this pr) is to get read of unused argument and simplify function call. Another one is to start using "path" argument at line 12 instead of "GetMasternodeConfigFile()" https://github.com/UdjinM6/darkcoin/blob/560b06fc3896d1f291fe8022cc3d45bdac3d49ef/src/masternodeconfig.cpp#L12