Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZMQ] append a message sequence number to every ZMQ notification #1082

Merged
merged 3 commits into from
Oct 17, 2016
Merged

[ZMQ] append a message sequence number to every ZMQ notification #1082

merged 3 commits into from
Oct 17, 2016

Conversation

chaeplin
Copy link

@chaeplin chaeplin commented Oct 17, 2016 •
edited
Loading

Code from bitcoin main branch.

  • Fixes ZMQ startup with bad arguments(7621)
  • [ZMQ] append a message sequence number to every ZMQ notification(7762)

contrib/zmq/zmq_sub.py to python 3 compatible

tested / sample log https://gist.github.com/chaeplin/cdeb14a8a5fcc7974109af30696224d0

@chaeplin
Zmq sequence (#1)
828d2c4 
* Fixes ZMQ startup with bad arguments.

pr 7621

* [ZMQ] append a message sequence number to every ZMQ notification

- pr 7762
- contrib/zmq/zmq_sub.py to python 3 compatible
@chaeplin chaeplin changed the title Zmq sequence (#1) [ZMQ] append a message sequence number to every ZMQ notification Oct 17, 2016
@chaeplin
Copy link
Author

travis-ci not passed

@chaeplin chaeplin closed this Oct 17, 2016
@UdjinM6
Copy link

UdjinM6 commented Oct 17, 2016

Yeah, this still happens sometimes for 32bit build. Failed at "-salvagewallet" this time which shouldn't be affected by changes here so I restarted the job. Feel free to reopen this if it passes.

@schinzelh
Copy link

Yeah, don't get dragged down by Travis - sometimes it just has a bad day :-)

@chaeplin chaeplin reopened this Oct 17, 2016
@chaeplin
typo in MSG_RAWTXLOCK
5bf0639 
MMSG_RAWTXLOCK to MSG_RAWTXLOCK
UdjinM6
UdjinM6 approved these changes Oct 17, 2016
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight dashification needed in docs, otherwise utACK

doc/zmq.md

There are several possibilities that ZMQ notification can get lost
during transmission depending on the communication type your are
using. Bitcoind appends an up-counting sequence number to each
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Bitcoind/Dashd/

@UdjinM6 UdjinM6 merged commit 9db6b97 into dashpay:v0.12.1.x Oct 17, 2016
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 9, 2022
@laanwj
Merge bitcoin#25202: log: Use severity-based logging for leveldb/libe…
4901631 
…vent messages, reverse LogPrintLevel order

c4e7717 refactor: Change LogPrintLevel order to category, severity (laanwj)
ce92071 leveldb: Log messages from leveldb with category and debug level (laanwj)
18ec120 http: Use severity-based logging for messages from libevent (laanwj)
bd971bf logging: Unconditionally log levels >= WARN (laanwj)

Pull request description:

  Log messages from leveldb and libevent libraries in the severity+level based log format introduced in bitcoin#24464.

  Example of messages before:
  ```
  2022-05-24T18:11:57Z [libevent] libevent: event_add: event: 0x55da963fcc10 (fd 10), EV_READ    call 0x7f1c7a254620
  2022-05-24T18:11:57Z [libevent] libevent: Epoll ADD(1) on fd 10 okay. Old events were 0; read change was 1 (add); write change was 0 (none); close change was 0 (none)
  2022-05-24T18:12:08Z leveldb: Generated table #609127@1: 6445 keys, 312916 bytes
  2022-05-24T18:12:08Z leveldb: Generated table #609128@1: 5607 keys, 268548 bytes
  2022-05-24T18:12:08Z leveldb: Generated table #609129@1: 189 keys, 9384 bytes
  2022-05-24T18:12:08Z leveldb: Generated table #609130@1: 293 keys, 13818 bytes
  ```

  Example of messages after:
  ```
  2022-05-24T17:59:52Z [libevent:debug] event_add: event: 0x5652f44dac10 (fd 10), EV_READ    call 0x7f210f2e6620
  2022-05-24T17:59:52Z [libevent:debug] Epoll ADD(1) on fd 10 okay. Old events were 0; read change was 1 (add); write change was 0 (none); close change was 0 (none)
  2022-05-24T17:59:53Z [leveldb:debug] Recovering log dashpay#1072
  2022-05-24T17:59:53Z [leveldb:debug] Level-0 table dashpay#1082: started
  2022-05-24T17:59:53Z [leveldb:debug] Level-0 table dashpay#1082: 193 bytes OK
  2022-05-24T17:59:53Z [leveldb:debug] Delete type=3 dashpay#1070
  2022-05-24T17:59:53Z [leveldb:debug] Delete type=0 dashpay#1072
  ```

  The first commit changes it so that messages with level Warning and Error are always logged independent of the `-debug` setting. I think this is useful to make sure warnings and errors, which tend to be important, are not lost. In the future this should be made more configurable.

  Last commit changes LogPrintLevel argument order to category, severity: This is more consistent with the other functions, as well as with the logging output itself. If we want to make this change, we should do it before it's all over the place.

ACKs for top commit:
  jonatack:
    Tested ACK c4e7717

Tree-SHA512: ea48a1517f8c1b23760e59933bbd64ebf09c32eb947e31b8c2696b4630ac1f4303b126720183e2de052bcede3a17e475bbf3fbb6378a12b0fa8f3582d610930d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaeplin @UdjinM6 @schinzelh