Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 2, 2016

This fixes bug I introduced in #1169 ...

Copy link

@tgflynn tgflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit c3e5757 into dashpay:v0.12.1.x Dec 2, 2016
@rebroad
Copy link

rebroad commented Dec 23, 2016

not much of a review process on this project - merged by the same person who wrote it with only one untested ACK... are there so few reviewers on here?

@UdjinM6
Copy link
Author

UdjinM6 commented Dec 23, 2016

¯\_(ツ)_/¯

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017
Fix was introdeced in:
dashpay#1169
A fix was later applied to fix a race condition:
dashpay#1178

This has to be reverted to be able to backport multiple changes from Bitcoin.
Later backported PRs from Bitcoin will remove cs_mapRelay and thus also
remove the deadlock that was initially fixed with the above PRs.
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
Fix was introdeced in:
dashpay#1169
A fix was later applied to fix a race condition:
dashpay#1178

This has to be reverted to be able to backport multiple changes from Bitcoin.
Later backported PRs from Bitcoin will remove cs_mapRelay and thus also
remove the deadlock that was initially fixed with the above PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants