Do not send outdated MNs on sync #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense but is there any reason to think this is causing problems ? |
|
I noticed that node was burning cpu and spamming debug.log processing few hundreds of outdated nodes which all came "in one pack". I guess it was also busy requesting invs at the very same time and as a result of this coincidence sync timed out too early. Even if that was not the main reason I guess it's no good to spam nodes with outdated MNs anyway (could probably add |
|
UPDATE_REQUIRED notes only represent about 10% of the total do I don't see this having a large effect. Still I don't see a downside so, utACK. |
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Feb 12, 2018
Reverts dashpay#1373, we need non-upgraded MNs to verify their old govvotes
Merged
UdjinM6
added a commit
that referenced
this pull request
Feb 12, 2018
* Do not filter non-upgraded mns in DSEG Reverts #1373, we need non-upgraded MNs to verify their old govvotes * Split mn list/single vin logic for DSEG This should prevent looping till the end of the list if we were asked for a single mn and a) we have it but some following `if` has failed or b) we don't have it. It also should be a bit easier to follow the logic this way.
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
* Do not filter non-upgraded mns in DSEG Reverts dashpay#1373, we need non-upgraded MNs to verify their old govvotes * Split mn list/single vin logic for DSEG This should prevent looping till the end of the list if we were asked for a single mn and a) we have it but some following `if` has failed or b) we don't have it. It also should be a bit easier to follow the logic this way.
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
* Do not filter non-upgraded mns in DSEG Reverts dashpay#1373, we need non-upgraded MNs to verify their old govvotes * Split mn list/single vin logic for DSEG This should prevent looping till the end of the list if we were asked for a single mn and a) we have it but some following `if` has failed or b) we don't have it. It also should be a bit easier to follow the logic this way.
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 2, 2019
* Do not filter non-upgraded mns in DSEG Reverts dashpay#1373, we need non-upgraded MNs to verify their old govvotes * Split mn list/single vin logic for DSEG This should prevent looping till the end of the list if we were asked for a single mn and a) we have it but some following `if` has failed or b) we don't have it. It also should be a bit easier to follow the logic this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.