fix CDSNotificationInterface::UpdatedBlockTip signature #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladcow
reviewed
Aug 4, 2017
| @@ -16,7 +16,7 @@ class CDSNotificationInterface : public CValidationInterface | |||
|
|
|||
| protected: | |||
| // CValidationInterface | |||
| void UpdatedBlockTip(const CBlockIndex *pindex); | |||
| void UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload); | |||
There was a problem hiding this comment.
May be we should use override keyword to prevent such errors in the future?
There was a problem hiding this comment.
Good idea 👍 I'll include this in the next one to keep cleanup/refactoring separate from bug fixing.
|
@OlegGirko |
to match the one in CValidationInterface
UdjinM6
force-pushed
the
fixUpdatedBlockTip
branch
from
0b72d25
to
34815bc
Compare
|
Pushed to trigger build restart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix it to match the one in
CValidationInterface.Thanks @chaeplin for reporting/digging/testing 👍